The committed gradle-wrapper.jar was the real 8.11.1 wrapper jar nested
inside another jar, without the org/gradle/cli classes, so ./gradlew failed
everywhere with NoClassDefFoundError: org/gradle/cli/CommandLineParser
(CI was the first place it ran from a fresh checkout). gradlew was a
hand-written launcher and gradlew.bat, which the dev guide tells Windows users
to run, did not exist.
Regenerated with `gradle wrapper --gradle-version 8.11.1` from the official
distribution (sha256 f397b287…, matching services.gradle.org); the jar matches
the published gradle-8.11.1-wrapper.jar.sha256 (2db75c40…). The distribution
URL is unchanged. .gitattributes pins gradlew to LF and *.bat to CRLF.
The UI review job starts its media fixture through server/node_modules/tsx,
so it installs the server's dependencies too.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- main is the long-lived development branch: release.yml no longer runs on
a push to it, only on v* tags and workflow_dispatch. ci.yml now runs on
every branch push, main included.
- android-actions/setup-android's default package list includes `tools`,
which current command-line tools no longer carry, so sdkmanager failed;
install exactly platform-tools, android-35 and build-tools 35.0.1.
- reader-chrome.test.ts left its React roots mounted; a scheduled commit
could land after jsdom teardown and fail the run with an unhandled
"Right-hand side of 'instanceof' is not an object" (all tests passing).
Unmount in afterEach.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
ci.yml (PRs, non-main pushes, and called by release.yml):
- server: typecheck, test, build
- web: typecheck, test (with server deps, for search parity), build
- UI review: production bundle in Playwright's Chromium, screenshots kept
- Android: shell contract check, web assets staged and verified, debug APK
release.yml (main, v* tags, manual):
- runs CI first; nothing is published from a red build
- builds hectorqin/reader-pro for linux/amd64 and linux/arm64 on native
runners (no QEMU), pushes by digest, then one job creates the multi-arch
tags: main + sha-<short> for main; x.y.z, x.y, latest + sha for tags
- needs DOCKERHUB_USERNAME and DOCKERHUB_TOKEN repository secrets
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
check-shell.sh failed on main in three places, none of them real defects:
- Every `fun` at method indentation counted as a bridge method, so the
Kotlin-only SpeechBridge.interruptForMedia (called by the media bridge,
not the page) was reported as undeclared. Only methods directly under
@JavascriptInterface are the page's contract now.
- configuredServerUrl was declared as an optional *property*
(`configuredServerUrl?: () => string`), which the declaration reader does
not see. Written as the equivalent optional method, `configuredServerUrl?(): string`.
- The package/directory check stripped only src/main/java/, so every unit
test under src/test/java/ was reported as misplaced. Any source set's java/
root is stripped now.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Reader
- The reading surface declared no touch-action, so the browser claimed every
horizontal drag (pointercancel): a swipe never turned a page on a phone, and
a rightward one triggered the browser's back gesture and left the book.
Paged and fixed layouts now leave every move to the gesture layer
(touch-action: none, on the host and on the paged column in the shadow
root); scroll mode keeps vertical panning only (pan-y), so it still scrolls
and no longer navigates away. Horizontal swipes in scroll mode stay inert.
Tabs
- useSwipeTabs (shared/ui): a clearly horizontal touch swipe moves one tab.
Mouse, short or diagonal moves, scrolls the browser took over, swipes that
start on a control or a sideways-scrolling row, and active selections are
ignored; the click the finger lifted over is suppressed. The entering body
slides in from the swipe side (header and tab row stay put; reduced motion
disables it).
- Media: the eight catalog tabs are one line across channels — 影视(首页 电影
剧集)→ 音乐(专辑 歌手 曲目)→ 有声书(有声书 演播者). Library and sort carry
over within a channel and reset across one.
- Shelf: 全部 · 在读 · 想读 · 已读.
Tests: swipe-tabs (gesture rules, catalog order and params) and the reader's
touch-action rules in reader-layout-css.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Paged mode
- Restoring the position after the viewport height changes (address bar,
keyboard, rotation) wrote max * fraction, which is almost never a column
boundary: the screen showed half of one page and half of the next. Every
paged scrollLeft write (restore, TTS follow, revealBlock, search) now goes
through one page-snapping helper, and a scroll the browser makes on its own
(focus, selection autoscroll) is snapped back.
Highlights
- localSectionId prefixed `xhtml:` from the format alone, so a windowed book
whose sections have no prefix saved highlights that matched no chapter and
were never drawn (and its progress failed to restore). The loaded document's
own section ids are now the authority.
- Highlight boxes are measured once; font size, margins, mode switch, resize
or a late image moved the text under them. They are repainted after each.
Mobile bottom bar
- `.reader-route-host` had min-height: 100vh, which on a phone browser is
taller than the visible viewport while the address bar shows, pushing the
reader's bottom toolbar under it. Height is 100dvh with a 100vh fallback.
- Notices are bottom-centre, exactly over 朗读/外观; in the reader they now
stack above the bottom bar instead of swallowing the next tap.
Tap to turn hides the toolbar
- A tap on the outer thirds turns the page and puts a showing toolbar away;
the middle third still toggles it.
UI review scripts: page-turn-regression waits for login to finish rather than
for the shelf (the app now opens on media); reader-regression shows the
toolbar before pressing 下一章 after tap turns.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Commands (per-package install/dev/test/build, single tests across the two web
runners, UI review) and the cross-file architecture: book identity, metadata
precedence, ShelfService as the only DTO builder, sync semantics, additive
schema, isolated media worker, hash routing and single-bundle constraints,
imperative reader stage.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Both screens showed an empty page with a floating "正在加载…" until the
first response. The .book-grid.is-skeleton styles (same grid and density as
the real one, a shimmer that goes flat under reduced motion) were already in
reader.css from the legacy shelf but nothing rendered them; BookGridSkeleton
does, so the first paint fills in instead of jumping.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The side-nav global search and the shelf's own field sat side by side on
desktop and both read "搜索书名、…"; the shelf one was even labelled
搜索书库 while it only filters the shelf.
- Global (side nav, /search): 搜索书籍和影音 — also no longer truncated in
the 216px rail.
- Shelf: 在书架中筛选书名、作者、系列, labelled 筛选书架; results are 筛选结果.
- Library: 在书库中搜索书名、作者.
- ui.md §4 records the rule.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
ui.md's four type roles only governed the reading side; the media sheets
used every integer from 8 to 24px plus dozens of rem values. Every font size
up to 24px now reads one of --text-display/title/body/ui/label/meta/micro.
- --text-ui (14px) is the media list/settings body; --text-display (22px) the
page hero; --text-micro (10px) only for cover/icon badges.
- --text-meta moves 0.72rem -> 0.75rem, so the 200+ media 12px lines land on
it unchanged and the reading side's meta grows by half a pixel.
- Inputs that were 16px land on --text-title (16.8px), keeping the iOS
focus-zoom floor; ui.md says so explicitly.
- Sizes above 24px (player initials, hero numerals) and the decorative serif
shorthands stay literal; the token test rejects literals <= 24px.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
client.js was one 1.48 MB bundle (413 kB gzip) because the build assumed the
Android shell loads from file://. It no longer does: WebHost serves the
bundle from https://appassets.androidplatform.net/ via WebViewAssetLoader,
the service worker precaches every emitted file, and the server serves any
file under assets/ (caching hashed names forever).
- The reader, media library/task/item admin pages and source editor pages
load on first visit (app/router/lazy-pages.tsx); wrappers keep the page
names, so the route tree and its tests read unchanged.
- Chunks are content-hashed; the entry stays client.js and CSS stays one
index.css, so no host-facing name changes and no unstyled flash.
- A tab running an old client after a deploy gets "应用已更新 · 重新加载"
instead of a dynamic-import error.
- ui:review now opens a book and asserts the reader chunk loads and renders.
client.js: 1478 kB -> 777 kB (gzip 413 -> 231 kB).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- 书库 / 文件管理 / 书源 headers used arrow-left while every media page uses
chevron-left; they now share chevron-left.
- The trailing "›" in collection links shared the label's flex: 1 and sat in
the middle of the button; it now ends the button in muted ink.
- On phones the 上传书籍 / 新建文件夹 actions split the row under the title
instead of hanging off the right edge.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A shelf of TXT books (or a media library before scraping) was a wall of
identical panels, so finding one meant reading every placeholder. Titles now
hash to one of twelve hues 30° apart (ui/cover-tint.ts), mixed 10-20% into
the theme surface, so the tint follows light/dark and the text on it keeps
its contrast. Shelf, library and media covers share it. ui.md §2.7.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The stylesheets used 2/3/4/5/6/7/8/9/10/11/12/13/14/15/18/19/20/22/24px plus
a dozen rem values for corners, so the same kind of control differed by a
pixel or two between neighbouring screens. --radius-xs/sm/md/lg/xl/pill
(4/8/10/14/20/999px) now carry every corner; --reader-radius is --radius-md.
Controls whose radius was half their height (switches, the role tag, the
home hero action, the nav icon pill) use --radius-pill so they stay capsules
if their height changes. ui.md §2.6 documents the scale; a test fails on any
new literal border-radius.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The light themes' brand fill (#F2B79F etc.) is softer than the white
secondary button beside it, so 保存/播放 read as the quieter choice. Primary
buttons now use brand-text with bg on it, the same recipe as danger, and a
pair the token spec already holds to 4.5:1 in every theme. brand stays for
state fills (selected, progress, switches). Spec updated (rule 6).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- Library editor / permissions: hide the frame header while the form (which
guards unsaved changes) draws its own; back labels say 返回媒体库管理.
- Media catalog: empty state renders below the library toolbar it describes.
- Video player: keep "elapsed / total" on phones instead of a dangling "/".
- Library browse: the count line is a static footer, not a sticky overlay.
- History: unplayable rows dim their play button and title.
- Shelf: drop the stale .shelf-status footer rule that indented the filter
chips; the subtitle no longer repeats the toolbar's count.
- Media browse settings: switches instead of checkboxes; labels keep one line.
- Sources: empty source picker links to 书源管理.
- Side nav: hover only on fine pointers, lighter than the selected state.
- Media tile titles match the shelf's weight.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- ActionMenu is an anchored dropdown on every width (popover, no title bar or backdrop; closes on pick, Escape, Tab or a press outside; arrow keys). ActionSheet stays for question-style picks. Styles in styles/action-menu.css.
- Remove the media settings home and its ⋯ entry: panels live only at /me/:panel; /media/:channel/settings[/:panel] redirects to 我的. Library and task pages return to 我的 or the channel.
- 插件管理: one list with status tags and a per-row ⋯ menu (启用/停用, 卸载 with confirmation); install moves into a Sheet (npm / local file, trust switch). Old plugin styles removed from reader.css.
- 首页: drop the redundant 继续阅读 pill on the reading card.
- Docs, unit tests and ui:review updated (stub admin settings in the media review).
- Replace every Mantine component with the toolkit (Button, Callout, IconButton) or plain markup; remove MantineProvider, its stylesheet and the --mantine variable bridge; keep its form-font reset in reader.css. Uninstall @mantine/core and @mantine/hooks.
- ActionMenu/ActionSheet (ui/action-menu.tsx): the file manager's Mantine Menu, the shelf pick dialog and the media <details> menus (catalog, narrators, detail, libraries, library rows, folders, chapters, queue, resource panel, favorites filter) are one compact Sheet menu.
- Toolkit Callout for page-level messages; operation failures go to FloatingNotice; .page-state for whole-page loading/error.
- Shared SourcesHeader and SourceBookDetailSheet; source editor and credentials pages rebuilt without Mantine, deleting a source now asks first.
- Remove dead code: SettingsPage (unrouted), MiniPlayer, ui/dom.ts (formatters moved to lib/format.ts), the unused metadata form dialog, useAppThemeDark.
- ui:review react-app passes again: fixed stale steps (/settings, mini player, login race, missing-edition detail).
- ui/sheet.tsx Sheet/ConfirmSheet replace the centred Modal, SweetAlert confirms, DialogView overlays, the reader Panel, the shelf settings floating card, the two media dialogs and Mantine Modal.
- Phones: bottom sheet. Wide windows: right-edge drawer; compact sheets (confirm, prompt, pick) open next to the tap or focused control.
- One set of exits (close, Escape, backdrop), 关闭 label, focus starts on 取消, danger confirms.
- Remove sweetalert2 and the unused @mantine/notifications.
- Remove the 来源与刮削 media settings panel and its entries in 我的 and 影音设置; TMDB and MusicBrainz stay configurable in 系统设置 > 服务配置.
- docs/ui.md 3.7 describes the rule; tests and review scripts follow the new markup.
- 首页: continue card on ch-read-soft with ink text, compact meter beside the action; media cards beside reading on wide windows; no repeated part title when length is unknown.
- 我的: soft profile card with role tag; groups in two top-to-bottom columns on wide windows, reading order restored on narrow ones; inset row separators.
- 8 我的(手机): 内容 / 偏好 / 管理 / 账号 as in the app; the list scrolls above the tab bar.
- New 20b 我的(桌面 · 设置中心): groups two to a row in the page column.
- Desktop 首页 / 书架 / 媒体库管理 use the shared 32px gutter (was 40px).
- 设计系统 notes the shared page column and that settings live in 我的.
- 首页/书架/影音/我的 share --page-measure and --page-gutter, so content edges stay put across tabs at every width; 我的 lays its groups two per row on wide screens.
- 我的 gathers every setting (偏好 / 管理 / 账号); its panels live at /me/:panel and return to 我的.
- 影音设置 keeps only media settings and links to 我的; 来源与刮削 is now reachable.
- 系统设置 moves from the shelf header to 我的 → 管理.
Server: user_books gains reading_status. The shelf list computes each
book's readingState — an explicit 在读/已读 mark wins, otherwise progress
decides (>=99% 已读, started 在读), and 想读 gives way once reading starts —
filters by ?status=, and PUT /api/v1/books/:id/reading-status sets or
clears the mark.
Client: chips 全部/在读/想读/已读 and 分组 (a series or a tag from the
shelf's facets) above the toolbar, all kept in the URL; a state label on
each cover; the ⋯ menu marks 想读/在读/已读, clears the mark, or takes the
book off the shelf.
Docs: API, UI and media user guide for this and the other V3.1 gaps.
Server:
- Scan jobs record the number of files listed (total), so a running scan
can report a real percentage.
- New 扫描设置 business settings, shown as the page's 扫描与元数据 card:
自动扫描新文件 (hourly rescan of every library, default on),
刮削封面与简介 (after a completed scan, scrape items that have no online
metadata and were never attempted, with the first configured provider;
default off), 读取内嵌字幕与歌词 (default on; off hides embedded subtitle
streams and lyrics tags), 扫描隐藏文件夹 (default off: names starting
with '.' are skipped, e.g. ._film.mp4 resource forks).
- MediaAutomation runs the scheduled scans and post-scan scraping as the
first active administrator; MediaScanner gains onFinished/isScanning.
Client:
- Each library card shows its latest scan: 上次扫描 今天 09:12 beside
重新扫描; 正在扫描 · 已处理 62% with a progress bar and 取消; or the
failure (路径不可访问…) with 重试 and 查看详情 (the tasks page).
Starting or cancelling a scan now stays on the page; scan-jobs is polled.
- 扫描与元数据 card beside the list saves each switch with the settings
revision, and hides itself on servers without these settings.
Prototype 12: 字幕, 音轨 and 版本 are tabs of one sheet. The subtitle tab
lists 关闭, sidecars (外挂 · srt), extracted and browser-embedded streams
(内嵌); 添加外挂字幕 converts an SRT/VTT/ASS file from the device to WebVTT
in the browser (UTF-8, UTF-16 or GB18030) and selects it for the session;
字幕延迟 shifts sidecar cues in 0.5 s steps from their original timing; 字号
(小/标准/大) is saved per device and drives ::cue.
Prototype 13: a 全屏 button enters full screen on the player, locks the
phone to landscape where allowed, and floats 选集, 倍速, 适应屏幕 (cover),
字幕 and 锁定 over the picture; they fade with DPlayer's controller. 锁定
stops taps from reaching the player until unlocked. Speed presets are also
in the 更多 sheet. All of this is web-only; the Android player keeps its
own menus.
The desktop sidebar gets the prototype's search box (搜索书名、片名、歌曲、有声书),
opening a new /search page that shows the first books (library index) and
media results with links to each full search. The account block shows the
sync engine's view of the server: 已连接, 正在同步, 离线 or 同步出错.
白纸 / 暖黄 / 浅绿 / 灰调 / 夜间 (prototypes 4 and 23) tint only the reading
page — paper, ink, readouts — while the chrome keeps the reading theme.
Stored per device in AppSettings (paper, paperFollowsDark), set from the
reader's 外观 sheet or 外观与主题. 夜间 makes the reader dark; a light paper
gives way to the theme's dark values while the app is dark unless
跟随系统深色模式 is off. Old sepia/green/dark page themes migrate to the
matching paper. Tokens are mirrored in TS and CSS and held to contrast by
theme-tokens.test.ts.
Implements docs/prototypes/Reader V3 主题语义令牌.md (v3.1):
- 暖陶 (default), 雾蓝, 青绿 app themes plus the reading-only 黑白灰, each
light and dark. Components read --color-* tokens from
styles/theme-tokens.css, selected by data-theme + data-mode; the
TypeScript mirror lives in shared/theme/theme.ts.
- Brand is split per the spec: brand/ch-* only fill (with on-brand/on-ch on
top), brand-text/ch-*-text for text. --reader-accent/--media-accent are now
brand text; --reader-fill/--media-fill are brand fills. Selected segmented
controls use brand-soft + brand-text.
- One preference per server+account (reader.theme.v2): app theme, mode
(system/light/dark), the follow-system light/dark pair, and the reading
theme. V3 choices migrate per spec §8 (rose falls back to 暖陶 light).
- 外观与主题 rebuilt from prototype 23: follow-system switch with the
light/dark pair, app-theme cards with light/dark previews, and the
reading theme (跟随应用 / 黑白灰).
- Reader: 黑白灰 is set on the reader container only; the appearance panel
offers 跟随应用/黑白灰 and 明暗; day/night sets the mode; the e-ink preset
uses 黑白灰 light.
- Video and music players wear the current theme's dark values (§4.7).
- Removed the legacy light/sepia/green/dark palettes and the
<html data-theme> writes from reader settings, which would now collide
with data-theme="green".
- Tests: theme-tokens.test.ts keeps CSS and TS values identical and checks
the §5 contrast pairs for all 8 palettes; theme.test.tsx covers migration,
resolution, the controller and the settings page.
The three media channels are a segmented control in the page header on phones
(the sidebar lists them from 701px up), and every channel page now has its
one h1. ChannelSwitcher, MediaChannelEntry, renderChannelLinks and the
legacy showChannelEntry are removed. Shell breakpoints move to 700/701px.
Review script react-app.mjs follows the new DOM (app-nav selectors, summary
and option roles for the favourites filter).
Mantine follows the app theme (colour scheme and primary/blue variables), so
the source editor, plugin page and dialogs stop being default blue.
Desktop video player puts the episode rail beside the picture and aligns the
tool row with it. 我的 and 首页 are top-level pages and lose the back arrow;
the theme page no longer says it only applies to media.
The book now wears the same six app themes as every other page (plus
follow-system); the separate white/sepia/green/dark reading themes are gone.
The 外观 sheet's swatches are the app themes drawn in their own colours and
the day/night rail button switches between 暖纸 and 深夜. The bottom bar
becomes a rounded sheet. 界面 is renamed 外观 in the bar, panel, review
scripts and spec.
Shelf title is 书架 in the serif face and loses the now-redundant headphones
link. docs/ui.md gains the V3 shell section.